-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalizing snarky yojson serializers to match kimchi common #15723
Conversation
!ci-build-me |
@@ -2,6 +2,7 @@ module Authorization_kind = struct | |||
module V1 = struct | |||
(* field for Proof is a verification key hash *) | |||
type t = Signature | Proof of Snark_params.Tick.Field.t | None_given | |||
[@@deriving yojson] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add this here; the wire_types
library should only contain types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've reimplemented this solution to not do this
!ci-build-me |
1 similar comment
!ci-build-me |
!ci-build-me |
!ci-build-me |
Closes #12591